Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-istio nightly #15393

Merged

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-istio.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-istio/latest/$x > ${GITHUB_WORKSPACE}/./third_party/istio-latest/$x
done

Details:

bumping knative.dev/net-istio 8aa5561...be4f06e:
  > be4f06e Revert https://github.com/knative-extensions/net-istio/pull/1085 (# 1344)

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2024
Copy link

knative-prow bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (44a5d78) to head (59a2786).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15393      +/-   ##
==========================================
+ Coverage   84.55%   84.58%   +0.03%     
==========================================
  Files         219      219              
  Lines       13587    13587              
==========================================
+ Hits        11488    11493       +5     
+ Misses       1729     1726       -3     
+ Partials      370      368       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

cc @ReToCode looks like istio tls tests are broken? but I thought they were skipped

@ReToCode
Copy link
Member

looks like istio tls tests are broken? but I thought they were skipped

Only the system-internal-tls ones are skipped. This is probably related to the revert. I'll take a look 👀

bumping knative.dev/net-istio 8aa5561...be4f06e:
  > be4f06e Revert knative-extensions/net-istio#1085 (# 1344)

Signed-off-by: Knative Automation <[email protected]>
@dprotaso dprotaso reopened this Jul 15, 2024
@knative-prow knative-prow bot merged commit fea0e7a into knative:main Jul 16, 2024
114 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants