-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in cert manager config #15434
Fix bug in cert manager config #15434
Conversation
Welcome @mstein11! It looks like this is your first PR to knative/serving 🎉 |
Hi @mstein11. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15434 +/- ##
=======================================
Coverage 84.53% 84.53%
=======================================
Files 219 219
Lines 13595 13595
=======================================
Hits 11492 11492
+ Misses 1736 1735 -1
- Partials 367 368 +1 ☔ View full report in Codecov by Sentry. |
SystemInternalIssuerRef: knativeSelfSignedIssuer, | ||
IssuerRef: knativeSelfSignedIssuer.DeepCopy(), | ||
ClusterLocalIssuerRef: knativeSelfSignedIssuer.DeepCopy(), | ||
SystemInternalIssuerRef: knativeSelfSignedIssuer.DeepCopy(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unmarshalling was affecting all pointers btw. So this returns a new pointer for each case with the same content.
/lgtm cc @mgencur fyi |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mstein11, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.15 |
@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dprotaso: new pull request created: #15437 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* add test to cover cert manager config edge case * fix edge case bug in cert manager config
* add test to cover cert manager config edge case * fix edge case bug in cert manager config Co-authored-by: mstein11 <[email protected]>
Fixes #15433
Release Note