Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a versioning mechanism for tracking the release of knative components. #2820

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

evankanderson
Copy link
Member

@evankanderson evankanderson commented Jan 1, 2019

Adds a label, serving.knative.dev/release, to all the yaml, and sets the tag during release to the ${TAG} value, if present. This should make it easier to identify what release is currently running in a cluster, and clean up old components after an upgrade.

Proposed Changes

  • Adds a label, serving.knative.dev/release, to all the yaml, and sets the tag during release to the ${TAG} value.
  • Development builds will be tagged with a devel label.

Release Note

* Adds a label, `serving.knative.dev/release` to knative serving components.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 1, 2019
@evankanderson
Copy link
Member Author

Not sure if we'd want to use a different release label for the monitoring components... would like your opinion.

/assign @mattmoor
/assign @adrcunha
/assign @mdemirhan

@jonjohnsonjr
Copy link
Contributor

There's a typo in your rrelease note.

@evankanderson
Copy link
Member Author

/retest

@mattmoor
Copy link
Member

🤔 I feel like we should be thinking through --prune for install cleanup as part of this change. WDYT?

@evankanderson
Copy link
Member Author

evankanderson commented Jan 18, 2019 via email

@mattmoor
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2019
@knative-prow-robot knative-prow-robot merged commit ad35b28 into knative:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants