-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a versioning mechanism for tracking the release of knative components. #2820
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not sure if we'd want to use a different release label for the monitoring components... would like your opinion. /assign @mattmoor |
There's a typo in your rrelease note. |
/retest |
🤔 I feel like we should be thinking through |
Did you have a particular concern or suggestion? I think if we install all
components into one namespace, the interesting question will be how to deal
with customization and configuration.
…On Thu, Jan 17, 2019, 5:35 PM Matt Moore ***@***.***> wrote:
🤔 I feel like we should be thinking through --prune for install cleanup
as part of this change. WDYT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2820 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHlyN4BzlF6KESs0YlNpv0PPFaUErXXUks5vESTfgaJpZM4ZlyAf>
.
|
/lgtm |
Adds a label,
serving.knative.dev/release
, to all the yaml, and sets the tag during release to the ${TAG} value, if present. This should make it easier to identify what release is currently running in a cluster, and clean up old components after an upgrade.Proposed Changes
serving.knative.dev/release
, to all the yaml, and sets the tag during release to the ${TAG} value.devel
label.Release Note