Ignore resources when DeletionTimestamp is set.
#3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
do-not-merge/work-in-progress
knative-prow-robot
requested review from
ericKlawitter,
josephburnett,
markusthoemmes,
mdemirhan and
tcnghia
mattmoor
force-pushed
the
support-finalizers
branch
5 times, most recently
from
8a16270
to
49e2c39
Compare
knative-prow-robot
added
size/M
mattmoor
changed the title
DeletionTimestamp is set.DeletionTimestamp is set.
knative-prow-robot
removed
the
do-not-merge/work-in-progress
mattmoor
force-pushed
the
support-finalizers
branch
from
49e2c39
to
f8f0647
Compare
|
It is notable that coverage is expected to fail due to some of our laggards, which sit below 80% |
vagababov
reviewed
Jan 30, 2019
When we had finalizers previously we would race with K8s GC to recreate our children as K8s reaped them. The simplest way to test this is to enable "foreground" deletion in our e2e tests, which is implemented as a finalizer. Fixes: knative#2678
mattmoor
force-pushed
the
support-finalizers
branch
from
f8f0647
to
68d109d
Compare
|
The following is the coverage report on pkg/.
|
|
@mattmoor: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ZhiminXiang
pushed a commit
to ZhiminXiang/serving-1
that referenced
this pull request
Feb 7, 2019
When we had finalizers previously we would race with K8s GC to recreate our children as K8s reaped them. The simplest way to test this is to enable "foreground" deletion in our e2e tests, which is implemented as a finalizer. Fixes: knative#2678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we had finalizers previously we would race with K8s GC to recreate our children as K8s reaped them.
The simplest way to test this is to enable "foreground" deletion in our e2e tests, which is implemented as a finalizer.
Fixes: #2678
WIP until #3035 merges