Pull in the knative/pkg update to make Severity less scary. #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, `Severity: Error` is always written to the API Server as `Severity: ""`. This is a backwards compatible change because for (drumroll) backwards compatibility in clients, we elected to make `"Error"` the default when omitted (so that the previously 100% terminal world w/o `Severity` mapped cleanly onto the new world). Fixes: knative#2507
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
size/M
|
cc @vaikas-google @evankanderson who were bugging me just yesterday about this ;-) |
|
/lgtm |
ZhiminXiang
pushed a commit
to ZhiminXiang/serving-1
that referenced
this pull request
Feb 7, 2019
…3038) With this change, `Severity: Error` is always written to the API Server as `Severity: ""`. This is a backwards compatible change because for (drumroll) backwards compatibility in clients, we elected to make `"Error"` the default when omitted (so that the previously 100% terminal world w/o `Severity` mapped cleanly onto the new world). Fixes: knative#2507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change,
Severity: Erroris always written to the API Server asSeverity: "".This is a backwards compatible change because for (drumroll) backwards compatibility in clients, we elected to make
"Error"the default when omitted (so that the previously 100% terminal world w/oSeveritymapped cleanly onto the new world).Fixes: #2507