Remove unnecessary functionality from the activator's codebase. #3494
Conversation
After introducing the throttling mechanism, a lot of the activator's functionality is no longer needed. In fact, the whole Activator interface is superfluous now.
knative-prow-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
In response to this:
After introducing the throttling mechanism, a lot of the activator's functionality is no longer needed. In fact, the whole Activator interface is superfluous now.
Fixes #1573
Proposed Changes
After introducing the throttling mechanism, a lot of the activator's functionality is no longer needed. In fact, the whole Activator interface is superfluous now.
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/assign @vagababov |
| serviceName = revision.Labels[serving.ServiceLabelKey] | ||
| } | ||
|
|
||
| a.Reporter.ReportRequestCount(namespace, serviceName, configurationName, name, httpStatus, attempts, 1.0) |
There was a problem hiding this comment.
I know this was here before, but do we want to report even if the names are empty?
Since this seems like a rouge request anyway?
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
|
@vagababov I think I'd like to keep that as-is for this PR. /hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
|
/test pull-knative-serving-integration-tests |
After introducing the throttling mechanism, a lot of the activator's functionality is no longer needed. In fact, the whole Activator interface is superfluous now.
Fixes #1573
Proposed Changes
After introducing the throttling mechanism, a lot of the activator's functionality is no longer needed. In fact, the whole Activator interface is superfluous now.
Release Note