Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch test images to strict mode #7180

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Switch test images to strict mode #7180

merged 1 commit into from
Mar 9, 2020

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Mar 7, 2020

My initial find/grep/sed only matched some of our main binaries. 🙄

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 7, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Mar 7, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Mar 7, 2020

/retest

@k4leung4
Copy link
Contributor

k4leung4 commented Mar 9, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-autotls-tests pull-knative-serving-autotls-tests 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-autotls-tests

@knative-prow-robot knative-prow-robot merged commit c78d9ee into knative:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@chizhg chizhg Awaiting requested review from chizhg

Assignees

@vagababov vagababov

@k4leung4 k4leung4

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattmoor @knative-prow-robot @k4leung4 @knative-test-reporter-robot @vagababov @googlebot