[WIP] Support per-path deadlines initialized from v1.Revision.Spec.TimeoutSeconds. #8203

richterdavid · 2020-06-04T16:50:04Z

Proposed Changes

Pass v1.Revision.Spec.TimeoutSeconds through as the deadline for request paths
If several revisions contribute to the same path, use the maximum of these

Release Note

Support per-path deadlines initialized from v1.Revision.Spec.TimeoutSeconds.

…into issue2201

…into richterdavid/issue2201

knative-prow-robot

@richterdavid: 2 warnings.

In response to this:

Fixes #2201

Proposed Changes

Pass v1.Revision.Spec.TimeoutSeconds through as the deadline for request paths

Pass config.Defaults.RevisionTimeoutSeconds for the default deadline and minimum deadline

If several revisions contribute to the same path, use the maximum of these

Release Note
Support per-path deadlines initialized from config.Defaults.RevisionTimeoutSeconds and v1.Revision.Spec.TimeoutSeconds.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/reconciler/route/resources/ingress.go

richterdavid · 2020-06-04T17:10:40Z

/test pull-knative-serving-unit-tests

richterdavid · 2020-06-04T17:15:08Z

/lint
/test all

…into richterdavid/issue2201

richterdavid · 2020-06-19T19:47:48Z

/test

knative-prow-robot · 2020-06-19T19:47:55Z

@richterdavid: The /test command needs one or more targets.
The following commands are available to trigger jobs:

/test pull-knative-serving-build-tests
/test pull-knative-serving-unit-tests
/test pull-knative-serving-integration-tests
/test pull-knative-serving-upgrade-tests
/test pull-knative-serving-autotls-tests
/test pull-knative-serving-go-coverage
/test pull-knative-serving-go-coverage-dev
/test pull-knative-serving-istio-1.5-mesh
/test pull-knative-serving-istio-1.5-no-mesh
/test pull-knative-serving-istio-1.4-mesh
/test pull-knative-serving-istio-1.4-no-mesh
/test pull-knative-serving-gloo-0.17.1
/test pull-knative-serving-kourier-stable
/test pull-knative-serving-contour-latest
/test pull-knative-serving-ambassador-latest
/test pull-knative-serving-https

Use /test all to run the following jobs:

pull-knative-serving-build-tests
pull-knative-serving-unit-tests
pull-knative-serving-integration-tests
pull-knative-serving-upgrade-tests
pull-knative-serving-autotls-tests
pull-knative-serving-go-coverage

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richterdavid · 2020-06-19T19:48:30Z

/test all

richterdavid · 2020-06-19T19:59:23Z

/test pull-knative-serving-unit-tests

richterdavid · 2020-06-19T22:35:44Z

/test pull-knative-serving-https

richterdavid · 2020-06-20T00:35:26Z

/test pull-knative-serving-https

…into richterdavid/issue2201

richterdavid · 2020-06-24T16:18:59Z

See discussion of this PR in slack:
https://knative.slack.com/archives/CA9RHBGJX/p1592591518025100

richterdavid · 2020-06-25T22:14:17Z

/test all

knative-metrics-robot · 2020-06-25T22:19:10Z

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/route/traffic/traffic.go	93.9%	94.1%	0.2

knative-test-reporter-robot · 2020-06-25T22:53:23Z

The following jobs failed:

Test name	Triggers	Retries
pull-knative-serving-integration-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests:

test/conformance/api/v1.TestRevisionTimeout
test/conformance/api/v1alpha1.TestRevisionTimeout
test/conformance/api/v1beta1.TestRevisionTimeout

…into richterdavid/issue2201

knative-prow-robot · 2020-06-29T15:42:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: richterdavid
To complete the pull request process, please assign dprotaso
You can assign the PR to them by writing /assign @dprotaso in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…into richterdavid/issue2201

richterdavid · 2020-07-01T16:07:22Z

This is blocked on knative/networking#22 being submitted and vendored in, to address feedback on Slack from @markusthoemmes

knative-prow-robot · 2020-08-10T21:48:15Z

@richterdavid: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

markusthoemmes · 2020-08-11T06:39:50Z

@richterdavid the relevant PR seems to have been merged. Any news on this one?

richterdavid · 2020-08-24T17:40:49Z

Sorry for the delay. I've been OOO for two weeks and am just getting caught up on things now that I'm back. I'll circle back to this PR when I have the chance.

…

On Mon, Aug 10, 2020 at 11:40 PM Markus Thömmes ***@***.***> wrote: @richterdavid <https://github.com/richterdavid> the relevant PR seems to have been merged. Any news on this one? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8203 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOXGKZU7P24D3EYRYL3DEULSADRUHANCNFSM4NSZUU6Q> .

knative-prow-robot · 2020-08-28T16:30:56Z

@richterdavid: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-serving-integration-tests	`96154d3`	link	`/test pull-knative-serving-integration-tests`
pull-knative-serving-kourier-stable	`96154d3`	link	`/test pull-knative-serving-kourier-stable`
pull-knative-serving-contour-latest	`96154d3`	link	`/test pull-knative-serving-contour-latest`
pull-knative-serving-istio-1.4-no-mesh	`96154d3`	link	`/test pull-knative-serving-istio-1.4-no-mesh`
pull-knative-serving-istio-1.5-no-mesh	`96154d3`	link	`/test pull-knative-serving-istio-1.5-no-mesh`
pull-knative-serving-https	`96154d3`	link	`/test pull-knative-serving-https`
pull-knative-serving-gloo-0.17.1	`96154d3`	link	`/test pull-knative-serving-gloo-0.17.1`
pull-knative-serving-istio-1.4-mesh	`96154d3`	link	`/test pull-knative-serving-istio-1.4-mesh`
pull-knative-serving-istio-1.5-mesh	`96154d3`	link	`/test pull-knative-serving-istio-1.5-mesh`
pull-knative-serving-ambassador-latest	`96154d3`	link	`/test pull-knative-serving-ambassador-latest`
pull-knative-serving-contour-tls	`525b400`	link	`/test pull-knative-serving-contour-tls`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

richterdavid · 2020-09-18T17:00:51Z

/close

knative-prow-robot · 2020-09-18T17:00:58Z

@richterdavid: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richterdavid added 17 commits May 5, 2020 16:58

make a note of where to change

c949070

Merge branch 'master' into issue2201

9df8c07

first draft

6593cf9

draft 2

d05f60b

fix casts

192eaa7

add todo

230f02b

passes ingress_test

237beaa

fix some failing tests

54d13e4

Merge branch 'master' into issue2201

1b12cd9

Merge branch 'master' of persistent-https://github.com/knative/serving …

2b91812

…into issue2201

Start passing Defaults through the stack

60ea08b

get defaults from context

cc6a323

fix compiler issues

4a2cc20

sync up, fix build errors and conflicts.

369ae7e

more fixes

d3997f2

lint fix

401ef2b

Merge branch 'master' of persistent-https://github.com/knative/serving …

d7873b3

…into richterdavid/issue2201

knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2020

knative-prow-robot reviewed Jun 4, 2020

View reviewed changes

pkg/reconciler/route/resources/ingress.go Outdated Show resolved Hide resolved

pkg/reconciler/route/resources/ingress.go Outdated Show resolved Hide resolved

knative-prow-robot requested review from mdemirhan and nak3 June 4, 2020 16:50

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 4, 2020

knative-prow-robot added area/API API objects and controllers area/networking labels Jun 4, 2020

richterdavid marked this pull request as draft June 4, 2020 16:51

richterdavid added 2 commits June 4, 2020 09:55

fix lint from prow

48df4ab

test fix

efb115d

Merge branch 'master' of persistent-https://github.com/knative/serving …

7cdb532

…into richterdavid/issue2201

add logging

8b3d6ef

knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jun 19, 2020

richterdavid added 2 commits June 19, 2020 17:34

names a const

99e1527

uses %#v for logging resources

6df41df

Merge branch 'master' of persistent-https://github.com/knative/serving …

96154d3

…into richterdavid/issue2201

Add TTFB doc to TimeoutSeconds.

d70b87c

richterdavid mentioned this pull request Jun 25, 2020

Removes unwanted timeout setting knative/networking#22

Merged

Merge branch 'master' of persistent-https://github.com/knative/serving …

0705dae

…into richterdavid/issue2201

Merge branch 'master' of persistent-https://github.com/knative/serving …

525b400

…into richterdavid/issue2201

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2020

knative-prow-robot closed this Sep 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Support per-path deadlines initialized from v1.Revision.Spec.TimeoutSeconds. #8203

[WIP] Support per-path deadlines initialized from v1.Revision.Spec.TimeoutSeconds. #8203

richterdavid commented Jun 4, 2020 •

edited

Loading

knative-prow-robot left a comment

richterdavid commented Jun 4, 2020

richterdavid commented Jun 4, 2020

richterdavid commented Jun 19, 2020

knative-prow-robot commented Jun 19, 2020

richterdavid commented Jun 19, 2020

richterdavid commented Jun 19, 2020

richterdavid commented Jun 19, 2020

richterdavid commented Jun 20, 2020

richterdavid commented Jun 24, 2020

richterdavid commented Jun 25, 2020

knative-metrics-robot commented Jun 25, 2020

knative-test-reporter-robot commented Jun 25, 2020

knative-prow-robot commented Jun 29, 2020

richterdavid commented Jul 1, 2020

knative-prow-robot commented Aug 10, 2020

markusthoemmes commented Aug 11, 2020

richterdavid commented Aug 24, 2020 via email

knative-prow-robot commented Aug 28, 2020

richterdavid commented Sep 18, 2020

knative-prow-robot commented Sep 18, 2020

[WIP] Support per-path deadlines initialized from v1.Revision.Spec.TimeoutSeconds. #8203

[WIP] Support per-path deadlines initialized from v1.Revision.Spec.TimeoutSeconds. #8203

Conversation

richterdavid commented Jun 4, 2020 • edited Loading

Proposed Changes

knative-prow-robot left a comment

Choose a reason for hiding this comment

Proposed Changes

richterdavid commented Jun 4, 2020

richterdavid commented Jun 4, 2020

richterdavid commented Jun 19, 2020

knative-prow-robot commented Jun 19, 2020

richterdavid commented Jun 19, 2020

richterdavid commented Jun 19, 2020

richterdavid commented Jun 19, 2020

richterdavid commented Jun 20, 2020

richterdavid commented Jun 24, 2020

richterdavid commented Jun 25, 2020

knative-metrics-robot commented Jun 25, 2020

knative-test-reporter-robot commented Jun 25, 2020

knative-prow-robot commented Jun 29, 2020

richterdavid commented Jul 1, 2020

knative-prow-robot commented Aug 10, 2020

markusthoemmes commented Aug 11, 2020

richterdavid commented Aug 24, 2020 via email

knative-prow-robot commented Aug 28, 2020

richterdavid commented Sep 18, 2020

knative-prow-robot commented Sep 18, 2020

richterdavid commented Jun 4, 2020 •

edited

Loading