Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PodSpec dry-run for unparented Configurations #8828

Merged
merged 2 commits into from
Jul 29, 2020
Merged

PodSpec dry-run for unparented Configurations #8828

merged 2 commits into from
Jul 29, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Jul 27, 2020 •
edited
Loading

Fixes #8730

Proposed Changes

  • If a Configuration has no parent Service, we apply dry-run on PodSpec during validation

Release Note

PodSpec DryRun also validates unparented (service-less) Configurations

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 27, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2020
knative-prow-robot
knative-prow-robot reviewed Jul 27, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whaught: 0 warnings.

In response to this:

Fixes ##8730

Proposed Changes

  • If a Configuration has no parent Service, we apply dry-run on PodSpec during validation

Release Note

PodSpec DryRun also validates unparented (service-less) Configurations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Jul 27, 2020
@whaught
Copy link
Contributor Author

whaught commented Jul 27, 2020

/assign @dprotaso

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/webhook/validate_unstructured.go Do not exist 87.9%

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@dprotaso
Copy link
Member

/retest

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests 2020-07-28 20:00:44.414 +0000 UTC
2020-07-28 20:56:45.552 +0000 UTC		 2/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests:

test/e2e.TestSvcToSvcViaActivator
test/e2e.TestSubrouteLocalSTS
test/e2e.TestWebSocket
test/e2e.TestSubrouteLocalSTS/fqdn
test/e2e.TestSvcToSvcViaActivator/b-disabled

@whaught
Copy link
Contributor Author

whaught commented Jul 28, 2020

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit 5ee8c9c into knative:master Jul 29, 2020
@whaught whaught deleted the config-dryrun branch July 31, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julz julz julz left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@dprotaso dprotaso Awaiting requested review from dprotaso

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend PodSpec DryRun to Configurations
7 participants
@whaught @knative-metrics-robot @dprotaso @knative-prow-robot @knative-test-reporter-robot @julz @googlebot