Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DomainMapping CRD and type #9714

Merged
merged 5 commits into from
Oct 7, 2020

Conversation

julz
Copy link
Member

@julz julz commented Oct 7, 2020

First part of #9713.

Adds a DomainMapping CRD in config/domain-mapping and a new corresponding type in a resurrected apis/serving/v1alpha1 package, and runs code-gen.

/assign @mattmoor @dprotaso

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 7, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Oct 7, 2020
@julz julz mentioned this pull request Oct 7, 2020
14 tasks
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@89fc5bd). Click here to learn what that means.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9714   +/-   ##
=========================================
  Coverage          ?   87.98%           
=========================================
  Files             ?      179           
  Lines             ?     8455           
  Branches          ?        0           
=========================================
  Hits              ?     7439           
  Misses            ?      772           
  Partials          ?      244           
Impacted Files Coverage Δ
cmd/autoscaler/main.go 13.26% <0.00%> (ø)
...g/apis/serving/v1alpha1/domainmapping_lifecycle.go 100.00% <100.00%> (ø)
pkg/apis/serving/v1alpha1/domainmapping_types.go 100.00% <100.00%> (ø)
pkg/apis/serving/v1alpha1/register.go 100.00% <100.00%> (ø)
pkg/autoscaler/bucket/bucket.go 100.00% <100.00%> (ø)
pkg/reconciler/autoscaling/kpa/scaler.go 88.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89fc5bd...5227161. Read the comment docs.

@mattmoor
Copy link
Member

mattmoor commented Oct 7, 2020

This generally LGTM. You plan to add Validate/Default (and wire into webhook) in a follow-on?

@julz
Copy link
Member Author

julz commented Oct 7, 2020

Yep, added that to the plan of attack in the tracking issue @mattmoor, just trying to keep each PR reasonably small

@mattmoor
Copy link
Member

mattmoor commented Oct 7, 2020

/lgtm
/approve

🎉

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@knative-prow-robot knative-prow-robot merged commit d0dcbd1 into knative:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants