Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to "vendor" test-infra/scripts #2068

Merged
merged 7 commits into from
May 21, 2020

Conversation

coryrc
Copy link
Contributor

@coryrc coryrc commented May 15, 2020

Tracks the contents of test-infra/scripts into each repo at
scripts/test-infra directory.

The script provides both installation assistance (with --first-time
command-line argument) as well as its usual function of updating
scripts/test-infra directory and is intended to be called by
hack/update-deps.sh in each repo. The --branch option lets you choose
a particular branch (instead of master) if desired.

Helps with #1823 (because knative/client is preventing rollout of new image through every release and needs script updates)

Tracks the contents of test-infra/scripts into each repo at
scripts/test-infra directory.

The script provides both installation assistance (with --first-time
command-line argument) as well as its usual function of updating
scripts/test-infra directory and is intended to be called by
hack/update-deps.sh in each repo. The --branch option lets you choose
a particular branch (instead of master) if desired.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 15, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2020
@coryrc
Copy link
Contributor Author

coryrc commented May 15, 2020

/assign @chizhg
/assign @chaodaiG
/assign @mattmoor
/assign @vaikas

@mattmoor
Copy link
Member

I'm not comfortable making a change of this magnitude less than a week before we are supposed to cut the test-infra/pkg release and pinning them everywhere. This should wait until the first week of 0.16.

TBH, I haven't heard a particularly clear articulation of what the problem is, so can we start with an issue that writes up the issue in detail before we prescribe solutions?

Even though this is the route we will probably not take
@chizhg
Copy link
Member

chizhg commented May 21, 2020

/lgtm
/hold
Feel free to unhold if you don't want to make changes for my comment.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels May 21, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@coryrc
Copy link
Contributor Author

coryrc commented May 21, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2020
@chizhg
Copy link
Member

chizhg commented May 21, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg, coryrc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@knative-prow-robot knative-prow-robot merged commit 21faa1b into knative:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants