-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create script to "vendor" test-infra/scripts #2068
Conversation
Tracks the contents of test-infra/scripts into each repo at scripts/test-infra directory. The script provides both installation assistance (with --first-time command-line argument) as well as its usual function of updating scripts/test-infra directory and is intended to be called by hack/update-deps.sh in each repo. The --branch option lets you choose a particular branch (instead of master) if desired.
I'm not comfortable making a change of this magnitude less than a week before we are supposed to cut the test-infra/pkg release and pinning them everywhere. This should wait until the first week of 0.16. TBH, I haven't heard a particularly clear articulation of what the problem is, so can we start with an issue that writes up the issue in detail before we prescribe solutions? |
Even though this is the route we will probably not take
/lgtm |
/unhold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chizhg, coryrc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tracks the contents of test-infra/scripts into each repo at
scripts/test-infra directory.
The script provides both installation assistance (with --first-time
command-line argument) as well as its usual function of updating
scripts/test-infra directory and is intended to be called by
hack/update-deps.sh in each repo. The --branch option lets you choose
a particular branch (instead of master) if desired.
Helps with #1823 (because knative/client is preventing rollout of new image through every release and needs script updates)