Support knex.raw in aggregates

[forivall]

knex should support use of raw in aggregates

For example: knex('table').count(knex.raw('distinct "column"') (postgres)
Current workaround: knex('table').select(knex.raw('count(distinct "column")')

Fix (would pull request, but needs tests): in clients/base/grammer.js; in compileAggregates

- if (aggregate.columns.toLowerCase().indexOf(' as ') !== -1) {
+ if (!(aggregate.columns instanceof Raw) && aggregate.columns.toLowerCase().indexOf(' as ') !== -1) {

An even better fix would be to support distinct with count natively.

[tgriesser]

I believe this should work now in 0.6. Please reopen if not the case.

[rooftopsparrow]

This is definitely still broken. I'm having the issue with latest knex. I set up this little scenario for testing:

create table blergs (id serial primary key, value text);
create table blags (id serial primary key, blerg_id integer references blags(id), num_things integer);
insert into blergs (value) values ('foo');
insert into blags (blerg_id, num_things) values (1, 2), (1, 3);
select sum(num_things) as total_things, count(distinct blerg_id) as num_blergs from blags;

results in:

 total_things | num_blergs 
-------------+------------
           5 |          1

// test.js
var config = { /* connection */ }
var knex = require('knex');
var k = knex(config)
var q = k.count(knex.raw('distinct blerg_id as num_blergs')).sum('num_things as total_things').from('blags');
q.then(function(result) { console.log(result); process.exit(0); }).catch(function(e) { console.error(e); process.exit(1) })

$ npm install pg knex@latest
$ node test.js
[TypeError: Object distinct blerg_id as num_blergs has no method 'toLowerCase']

but the workaround @forivall suggested works great.

[absolux]

It might be closed now, since countDistinct() is available

[elhigu]

@absolux yep, if anyone likes to have some more features related to this, new issue should be opened.