Properly use optional parameters in declaration file test #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion on DefinitelyTyped/DefinitelyTyped#34699 for details.
|
Should the declaration be the one that's changed? https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html#optional-parameters-in-callbacks |
|
I dunno. I operated on the assumption that the types were correct and that the callback could legitimately be called we fewer than all its possible arguments - I'm not familiar enough with knockout's implementation to know. |
|
The problem is actually in DefinitelyTyped's definition for |
weswigham
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Apr 15, 2019
Following discussion about #34699 on knockout/knockout#2475
alesn
pushed a commit
to alesn/DefinitelyTyped
that referenced
this pull request
Apr 23, 2019
Following discussion about DefinitelyTyped#34699 on knockout/knockout#2475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion on DefinitelyTyped/DefinitelyTyped#34699 for details.