Update TradeOgreAdapters.java that is building a reversed CurrencyPair #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the CurrencyPair that is buiding wrong using COUNTER-BASE and should be BASE-COUNTER
|
Hello francitoshi |
bigscoop
reviewed
May 7, 2024
| @@ -23,7 +23,7 @@ | |||
| public class TradeOgreAdapters { | |||
|
|
|||
| public static String adaptCurrencyPair(CurrencyPair currencyPair) { | |||
| return currencyPair.counter.toString() + "-" + currencyPair.base.toString(); | |||
There was a problem hiding this comment.
please use getters instead of direct field access
There was a problem hiding this comment.
I'm using it on a project, and this just the change I need, I'll try to fix tests and use getters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the CurrencyPair that is buiding wrong using COUNTER-BASE and should be BASE-COUNTER