Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy app work #4

Merged
merged 10 commits into from
May 23, 2022
Merged

Dummy app work #4

merged 10 commits into from
May 23, 2022

Conversation

charlesfries
Copy link
Collaborator

@charlesfries charlesfries commented Mar 9, 2022 •
edited
Loading

  • Use RESTAdapter/RESTSerializer
  • Fix adapter error handling
  • Use single() Supabase modifier
  • Fix serialization
  • Support sideloading/joins
  • Add tests
  • Upgrade to Ember 4
  • Add basic realtime support

@charlesfries
misc: General changes
8ed9167 
- Migrate back to RESTAdapter/RESTSerializer
- Upgrade to latest Ember
- Add more examples
@charlesfries charlesfries marked this pull request as ready for review May 22, 2022 05:23
@charlesfries
Copy link
Collaborator Author

I believe this is ready for merging. Would you mind doing a prerelease as well when you have time?

@knownasilya
Copy link
Owner

@charlesfries I'll add you to npm as well. What's your handle there?

@charlesfries
Copy link
Collaborator Author

@charlesfries on npm

knownasilya
knownasilya requested changes May 23, 2022
View reviewed changes
Copy link
Owner

@knownasilya knownasilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things, otherwise it looks good.

tests/dummy/app/controllers/database/create-record.ts Outdated Show resolved Hide resolved
tests/dummy/app/controllers/authentication.ts Outdated Show resolved Hide resolved
tests/dummy/app/controllers/authentication.ts Outdated Show resolved Hide resolved
addon/serializers/supabase.ts Outdated Show resolved Hide resolved
tests/dummy/app/controllers/database/update-record.ts Outdated Show resolved Hide resolved
tests/dummy/config/environment.js Show resolved Hide resolved
@knownasilya knownasilya merged commit 6a71c6a into knownasilya:main May 23, 2022
@knownasilya knownasilya added the enhancement New feature or request label May 23, 2022
@charlesfries charlesfries deleted the misc branch May 23, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knownasilya knownasilya knownasilya approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesfries @knownasilya