Make utern print logs as many as possible #31
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abicky
force-pushed
the
make-utern-print-logs-as-many-as-possible
branch
from
2d5bc3c
to
34b741d
Compare
The responses from FilterLogEvents API include only logs with a timestamp after the value `startTime` but utern uses the last ingestion time of the last response, which is usually larger than the last event time, that is, utern ignores some logs that occurred before the last ingestion time. This commit makes utern use the minimum value of event times to print logs as much as possible.
abicky
force-pushed
the
make-utern-print-logs-as-many-as-possible
branch
from
34b741d
to
812ef09
Compare
yutachaos
approved these changes
Oct 7, 2021
|
I don't have an environment to test it. We can merge it as @yutachaos approved 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
There is no issue because it is difficult to reproduce the issue, but I believe some users, especially those who have applications that print many logs to a log group with multiple streams in a short time, have experienced it.
Description of changes:
The responses from FilterLogEvents API include only logs with a timestamp after the value
startTimebut utern uses the last ingestion time of the last response, which is usually larger than the last event time, that is, utern ignores some logs that occurred before the last ingestion time.This PR makes utern use the maximum value of event times to print logs as much as possible.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.