impl Format for NonZero*
#509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-schievink
approved these changes
Jun 16, 2021
src/impls/core_/num.rs
Outdated
| ($type:ty) => { | ||
| impl Format for $type { | ||
| fn format(&self, fmt: Formatter) { | ||
| crate::write!(fmt, "{}", self.get()); |
There was a problem hiding this comment.
This format string could specify the type directly, which would be more efficient. Not a blocker, but please create an issue tracking this (or add a FIXME) if you don't want to do it in this PR.
There was a problem hiding this comment.
I see. I will try to do it here.
Urhengulas
force-pushed
the
format-for-nonzero
branch
from
4284704
to
d856ef2
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501