Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't print leading space when timestamp is absent #535

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Don't print leading space when timestamp is absent #535

merged 1 commit into from
Jul 16, 2021

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Jul 16, 2021 •
edited
Loading

This was causing aesthetically unpleasing output and thus makes defmt completely unusable:

 INFO  (11/11) running `ext_roundtrip`...
└─ integration::tests::__defmt_test_entry @ tests/integration.rs:330
 INFO  all tests passed!
└─ integration::tests::__defmt_test_entry @ tests/integration.rs:4

Now it should look like

INFO  (11/11) running `ext_roundtrip`...
└─ integration::tests::__defmt_test_entry @ tests/integration.rs:330
INFO  all tests passed!
└─ integration::tests::__defmt_test_entry @ tests/integration.rs:4

Fixes knurling-rs/probe-run#230

japaric
japaric approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@japaric
Copy link
Member

japaric commented Jul 16, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 16, 2021

Build succeeded:

@bors bors bot merged commit ea22487 into knurling-rs:main Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@japaric japaric japaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log lines start with a space
2 participants
@jonas-schievink @japaric