Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defmt::flush() #550

Merged
merged 12 commits into from
Sep 8, 2021
Merged

defmt::flush() #550

merged 12 commits into from
Sep 8, 2021

Conversation

Urhengulas
Copy link
Member

@Urhengulas Urhengulas commented Jul 22, 2021

Fixes #515

TODO

  • skeleton: add method to trait, TODO-implements in crates and tests
  • defmt-rtt
  • defmt-semihosting
  • defmt-itm
  • adapt delays based on docs and testing

macros/src/attributes/global_logger.rs Outdated Show resolved Hide resolved
firmware/defmt-rtt/src/lib.rs Outdated Show resolved Hide resolved
src/traits.rs Outdated Show resolved Hide resolved
src/export.rs Outdated Show resolved Hide resolved
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replied to TODO questions

firmware/defmt-rtt/src/lib.rs Outdated Show resolved Hide resolved
firmware/defmt-rtt/src/lib.rs Outdated Show resolved Hide resolved
firmware/defmt-rtt/src/lib.rs Outdated Show resolved Hide resolved
firmware/defmt-rtt/src/lib.rs Outdated Show resolved Hide resolved
firmware/defmt-semihosting/src/lib.rs Outdated Show resolved Hide resolved
src/traits.rs Outdated Show resolved Hide resolved
firmware/defmt-rtt/src/lib.rs Outdated Show resolved Hide resolved
firmware/defmt-itm/src/lib.rs Outdated Show resolved Hide resolved
firmware/defmt-rtt/src/lib.rs Outdated Show resolved Hide resolved
firmware/defmt-rtt/src/lib.rs Outdated Show resolved Hide resolved
@Urhengulas Urhengulas marked this pull request as ready for review September 6, 2021 11:37
firmware/defmt-rtt/src/lib.rs Outdated Show resolved Hide resolved
firmware/defmt-itm/src/lib.rs Outdated Show resolved Hide resolved
src/export.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 8, 2021

Build succeeded:

@bors bors bot merged commit 59d2074 into main Sep 8, 2021
@bors bors bot deleted the flush branch September 8, 2021 16:55
bors bot added a commit that referenced this pull request Oct 19, 2021
547: Migration guide `v0.2.x` to `v0.3.0` r=japaric a=Urhengulas

Migration guide from `defmt v0.2.x` to version `v0.3.0`.

https://deploy-preview-547--admiring-dubinsky-56dff5.netlify.app/migration-02-03.html

Fixes #530.

### TODO
- [x] #505: Logger trait v2
- [x] #521: [3/n] Remove u24
- [x] #522: Replace `µs` hint with `us`
- [x] (no adaption needed) ~~#508: [5/n] Format trait v2~~
- [x] #519: `DEFMT_LOG`
- [x] #550: `defmt::flush()`
- [x] knurling-rs/probe-run#198, knurling-rs/probe-run#250, 

Co-authored-by: Johann Hemmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defmt: flush API
3 participants