Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Add RTT input support. #73

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add RTT input support. #73

wants to merge 1 commit into from

Conversation

Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Sep 28, 2020

This PR adds RTT input support on down channel 0. It is enabled with flag --input (not on by default).

Since defmt-rtt doesn't expose RTT, this can be used with a custom defmt logger implementation such as this one (example).

Missing things:

  • To read from stdin in the main loop, it is switched to nonblocking mode. This currently only works on unixes. Don't know if there's a Windows equivalent or we should read stdin from a separate thread.
  • Input is only sent after pressing Return. We could switch to raw mode so every keystroke is sent, but IMO it should be optional since the host terminal's line editing is useful.

@Urhengulas Urhengulas added the pr waits on: author Pull Request requires changes from the author label Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr waits on: author Pull Request requires changes from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants