Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kind image loading for MacOS #1057

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

aidy
Copy link
Contributor

@aidy aidy commented May 26, 2023

See: kubernetes-sigs/kind#2957

Fixes test following #1054

@codecov-commenter
Copy link

Codecov Report

Merging #1057 (ab31edd) into main (ccc0627) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   52.82%   52.82%           
=======================================
  Files          43       43           
  Lines        3360     3360           
=======================================
  Hits         1775     1775           
  Misses       1359     1359           
  Partials      226      226           
Impacted Files Coverage Δ
pkg/publish/kind/write.go 85.71% <100.00%> (ø)

@cpanato cpanato requested a review from imjasonh July 7, 2023 12:58
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@psankar
Copy link

psankar commented Nov 22, 2023

@cpanato @imjasonh Will this MR be merged ? I am running into the same issue when trying to use Ko on a M series mac

@imjasonh imjasonh reopened this Nov 22, 2023
@imjasonh imjasonh merged commit 59a676e into ko-build:main Nov 22, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants