Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove refs to deprecated io/ioutil #1092

Merged
merged 2 commits into from
Aug 23, 2023
Merged

chore: remove refs to deprecated io/ioutil #1092

merged 2 commits into from
Aug 23, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Jul 7, 2023

No description provided.

cpanato
cpanato previously requested changes Jul 7, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR
please check the error

Signed-off-by: guoguangwu <[email protected]>
@imjasonh
Copy link
Member

Thanks for this contribution! It looks good, I'm not sure why CI is stuck. I'll try closing/reopening, but if that doesn't work maybe rebase?

@imjasonh imjasonh closed this Aug 23, 2023
@imjasonh imjasonh reopened this Aug 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1092 (b262352) into main (1586ee4) will decrease coverage by 3.64%.
Report is 33 commits behind head on main.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
- Coverage   52.82%   49.19%   -3.64%     
==========================================
  Files          43       44       +1     
  Lines        3360     3653     +293     
==========================================
+ Hits         1775     1797      +22     
- Misses       1359     1624     +265     
- Partials      226      232       +6     
Files Changed Coverage Δ
pkg/commands/config.go 56.79% <ø> (-1.11%) ⬇️
pkg/internal/testing/daemon.go 0.00% <0.00%> (ø)
pkg/commands/resolver.go 36.44% <50.00%> (ø)
pkg/build/gobuild.go 57.29% <66.66%> (ø)

... and 1 file with indirect coverage changes

@imjasonh imjasonh enabled auto-merge (squash) August 23, 2023 17:23
@imjasonh imjasonh merged commit d4a1cc9 into ko-build:main Aug 23, 2023
23 checks passed
@testwill testwill deleted the ioutil branch August 24, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants