feat: add template params for platform info #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmittler
changed the title
|
@nmittler please sign the DCO |
|
@cpanato done |
|
@cpanato let me know if there's anything else I need to do. I've noticed a number of open PRs that seem to be stalled for over a month. It would be great to get this change in. |
nmittler
changed the title
nmittler
force-pushed
the
template-params
branch
3 times, most recently
from
0db2a19
to
9902785
Compare
This restructures the build logic in order to expand the buildArgs to include: - `Env`: the actual environment variables used to execute the build. This includes platform info (e.g. `GOOS`, `GOARCH`). - `GoEnv`: the map of variables from `go env`, but overridden with any platform-specific values defined in `Env`. Fixes ko-build#1301 Signed-off-by: Nathan Mittler <[email protected]>
imjasonh
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restructures the build logic in order to expand the buildArgs to include:
Env: the actual environment variables used to execute the build. This includes platform info (e.g.GOOS,GOARCH).GoEnv: the map of variables fromgo env, but overridden with any platform-specific values defined inEnv.Fixes #1301