Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document setup-ko in README.md #484

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

imjasonh
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #484 (972812b) into main (6447264) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   53.13%   53.13%           
=======================================
  Files          36       36           
  Lines        1848     1848           
=======================================
  Hits          982      982           
  Misses        715      715           
  Partials      151      151           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6447264...972812b. Read the comment docs.

@halvards
Copy link
Collaborator

LGTM. Should we also link to the GHCR docs for connecting the image to the repo, either here or in the actions readme?

@imjasonh
Copy link
Member Author

imjasonh commented Oct 26, 2021

LGTM. Should we also link to the GHCR docs for connecting the image to the repo, either here or in the actions readme?

I'd really like ko to just detect and do this automatically (#366), and not make it something the user even has to think about. We could document how to do it today (along the lines of #221 (comment)), but eventually it shouldn't be necessary at all.

edit: I guess the GitHub Actions equivalent would be:

ko publish \
  --image-label org.opencontainers.image.source=https://github.com/${{ github.repository }} \
  --image-label org.opencontainers.image.revision=${{ github.sha }} \
   ./cmd/app

@halvards
Copy link
Collaborator

Or even ${{ github.server_url }}/${{ github.repository }}, to support GitHub Enterprise users.

@imjasonh imjasonh merged commit 52d42d8 into ko-build:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants