Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Imply current import path #717

Merged
merged 2 commits into from
Jun 16, 2022
Merged

build: Imply current import path #717

merged 2 commits into from
Jun 16, 2022

Conversation

imjasonh
Copy link
Member

This changes ko build to not require any positional arg, and instead assume the positional arg . if none is passed.

This means that ko build can be invoked exactly, without any args, and has the same effect as ko build . or ko build ./.

This matches the behavior of go build.

@imjasonh imjasonh requested a review from mattmoor May 31, 2022 15:47
@imjasonh imjasonh merged commit 1a5551d into ko-build:main Jun 16, 2022
@imjasonh imjasonh mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjasonh @jonjohnsonjr