Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cosign, fix breakage #718

Closed
wants to merge 1 commit into from
Closed

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented May 31, 2022

$ go get -u github.com/sigstore/cosign
go get -u github.com/sigstore/cosign@latest
go: downloading github.com/sigstore/cosign v1.8.0
go: upgraded github.com/sigstore/cosign v1.3.2-0.20211120003522-90e2dcfe7b92 => v1.8.0
$ go get ./...
$ go mod tidy
$ go mod vendor
$ go build ./...
# github.com/google/ko/pkg/build
pkg/build/gobuild.go:351:20: undefined: types.CycloneDXMediaType

The const got renamed some time between 1.3.1 and 1.8.0: https://pkg.go.dev/github.com/sigstore/[email protected]/pkg/types

Fixes #713

Notably, some time between 1.3.1 and 1.8.0, the vendored cosign dependency seems to have grown by ~180k lines... 😒

@imjasonh imjasonh requested a review from mattmoor May 31, 2022 15:54
@imjasonh imjasonh changed the title Bump cosign Bump cosign, fix breakage May 31, 2022
@imjasonh
Copy link
Member Author

Superceded by #667 which bumps even more deps.

@imjasonh imjasonh closed this May 31, 2022
@imjasonh imjasonh mentioned this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails when upgrading to 1.18
1 participant