Have --image-refs list all images for multi-arch builds.
#761
Conversation
This change alters the behavior of `--image-refs` to also include all of the image references when a multi-architecture build is being performed.
| return nil | ||
| }); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Do we need this to fallthrough to also log the index? Can you add a tests?
There was a problem hiding this comment.
you can't fallthrough in non-expression switch statements, but the walk touches everything.
Looking at tests, if my next meeting is cancelled 🤞
There was a problem hiding this comment.
... or until then :)
There was a problem hiding this comment.
ok, I tweaked the tests to use images/indices and this has coverage now.
Codecov Report
@@ Coverage Diff @@
## main #761 +/- ##
==========================================
+ Coverage 51.24% 51.30% +0.05%
==========================================
Files 44 44
Lines 3323 3339 +16
==========================================
+ Hits 1703 1713 +10
- Misses 1407 1412 +5
- Partials 213 214 +1
Continue to review full report at Codecov.
|
| t.Errorf("buf.String() = %s, wanted %s", got, want) | ||
| refs := strings.Split(strings.TrimSpace(buf.String()), "\n") | ||
|
|
||
| for _, s := range refs { |
There was a problem hiding this comment.
Is len(refs) what we expect?
This change alters the behavior of
--image-refsto also include all of the image references when a multi-architecture build is being performed.