Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ko deps #770

Merged
merged 6 commits into from
Jul 21, 2022
Merged

Deprecate ko deps #770

merged 6 commits into from
Jul 21, 2022

Conversation

imjasonh
Copy link
Member

Fixes #769

@imjasonh imjasonh added this to the 0.12 milestone Jul 19, 2022
mattmoor
mattmoor previously approved these changes Jul 19, 2022
@imjasonh
Copy link
Member Author

It seems that Deprecated in cobra means the command also gets hidden from ko help and generated Markdown docs. If that's not something we want, I can try to figure out how to make that not happen.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #770 (8c207b4) into main (7ac1a03) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
+ Coverage   51.27%   51.30%   +0.02%     
==========================================
  Files          44       44              
  Lines        3321     3323       +2     
==========================================
+ Hits         1703     1705       +2     
  Misses       1401     1401              
  Partials      217      217              
Impacted Files Coverage Δ
pkg/commands/deps.go 14.42% <100.00%> (+0.83%) ⬆️
pkg/commands/run.go 22.12% <100.00%> (+0.69%) ⬆️

@imjasonh imjasonh changed the title Deprecate ko deps and ko run Deprecate ko deps Jul 21, 2022
@imjasonh imjasonh merged commit 562039f into ko-build:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: deprecate ko run and ko deps?
4 participants