Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove repeated error message on failure #921

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jan 4, 2023

Cobra logs error messages before passing them to us, so we don't need to re-log it.

Before:

ko build ./blah
Error: failed to publish images: importpath "ko://./blah" is not supported: importpath is not `package main`
2023/01/04 11:30:41 error during command execution:failed to publish images: importpath "ko://./blah" is not supported: importpath is not `package main`
exit status 1

After:

go run . build ./blah
Error: failed to publish images: importpath "ko://./blah" is not supported: importpath is not `package main`
exit status 1

@imjasonh imjasonh merged commit f987fba into ko-build:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants