Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bug between credentials and origin #85

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

TyrealHu
Copy link
Contributor

@TyrealHu TyrealHu commented Jul 15, 2022

Checklist

cannot set Access-Control-Allow-Origin to *, when Access-Control-Allow-Credentials is true

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@TyrealHu
Copy link
Contributor Author

cannot set Access-Control-Allow-Origin to *, when Access-Control-Allow-Credentials is true

@fengmk2
Copy link
Member

fengmk2 commented Aug 19, 2022

@TyrealHu Can you add a test for this change?

@TyrealHu
Copy link
Contributor Author

@fengmk2 Of course,i will add a test later.btw i think you should reconfigure the Node.js CI🐛

@TyrealHu
Copy link
Contributor Author

@fengmk2 i have already added a unit test for this feature, thx❤️

@fengmk2
Copy link
Member

fengmk2 commented Aug 19, 2022

@fengmk2 fengmk2 added the bug label Aug 19, 2022
@fengmk2 fengmk2 merged commit 1205356 into koajs:master Aug 19, 2022
@fengmk2
Copy link
Member

fengmk2 commented Aug 19, 2022

3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants