fix: the req data should be consumed on error (#33)

closes eggjs/egg#2897

.travis.yml

@@ -2,7 +2,7 @@ sudo: false
 language: node_js
 node_js:
   - '8'
-  - '9'
+  - '10'
 install:
   - npm i npminstall && npminstall
 script:

LICENSE

@@ -1,7 +1,7 @@
 The MIT License (MIT)
 
 Copyright (c) 2014 node_modules.
-Copyright (c) 2015 - 2016 koajs and other contributors.
+Copyright (c) 2015 - present koajs and other contributors.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

appveyor.yml

@@ -1,7 +1,7 @@
 environment:
   matrix:
     - nodejs_version: '8'
-    - nodejs_version: '9'
+    - nodejs_version: '10'
 
 install:
   - ps: Install-Product node $env:nodejs_version

index.js

@@ -4,6 +4,7 @@ const http = require('http');
 const path = require('path');
 const fs = require('fs');
 const escapeHtml = require('escape-html');
+const sendToWormhole = require('stream-wormhole');
 
 const env = process.env.NODE_ENV || 'development';
 const isDev = env === 'development';
@@ -30,6 +31,9 @@ module.exports = function onerror(app, options) {
     // to node-style callbacks.
     if (err == null) return;
 
+    // ignore all pedding request stream
+    if (this.req) sendToWormhole(this.req);
+
     // wrap non-error object
     if (!(err instanceof Error)) {
       const newError = new Error('non-error thrown: ' + err);

package.json

@@ -30,22 +30,26 @@
   "homepage": "https://github.com/koajs/onerror",
   "devDependencies": {
     "autod": "*",
+    "co-busboy": "^1.4.0",
     "egg-bin": "^4.3.5",
     "egg-ci": "1",
     "eslint": "4",
     "eslint-config-egg": "5",
-    "ko-sleep": "*",
+    "formstream": "^1.1.0",
     "koa": "2",
+    "mz-modules": "^2.1.0",
     "pedding": "1",
-    "supertest": "3"
+    "supertest": "3",
+    "urllib": "^2.29.1"
   },
   "engines": {
     "node": ">= 8.0.0"
   },
   "ci": {
-    "version": "8, 9"
+    "version": "8, 10"
   },
   "dependencies": {
-    "escape-html": "^1.0.3"
+    "escape-html": "^1.0.3",
+    "stream-wormhole": "^1.1.0"
   }
 }

test/accepts.test.js

@@ -21,18 +21,18 @@ describe('accepts.test.js', function() {
     app.use(commonError);
 
     request(app.callback())
-    .get('/user.json')
-    .set('Accept', '*/*')
-    .expect(500)
-    .expect('Content-Type', 'application/json; charset=utf-8')
-    .expect({ error: 'foo is not defined' }, done);
+      .get('/user.json')
+      .set('Accept', '*/*')
+      .expect(500)
+      .expect('Content-Type', 'application/json; charset=utf-8')
+      .expect({ error: 'foo is not defined' }, done);
 
     request(app.callback())
-    .get('/user')
-    .set('Accept', 'application/json')
-    .expect(500)
-    .expect('Content-Type', 'text/plain; charset=utf-8')
-    .expect('foo is not defined', done);
+      .get('/user')
+      .set('Accept', 'application/json')
+      .expect(500)
+      .expect('Content-Type', 'text/plain; charset=utf-8')
+      .expect('foo is not defined', done);
   });
 
   it('should redrect when accepts type not json', function(done) {
@@ -50,12 +50,12 @@ describe('accepts.test.js', function() {
     app.use(commonError);
 
     request(app.callback())
-    .get('/user')
-    .set('Accept', '*/*')
-    .expect('Content-Type', 'text/html; charset=utf-8')
-    .expect('Location', 'http://foo.com/500.html')
-    .expect('Redirecting to <a href="http://foo.com/500.html">http://foo.com/500.html</a>.')
-    .expect(302, done);
+      .get('/user')
+      .set('Accept', '*/*')
+      .expect('Content-Type', 'text/html; charset=utf-8')
+      .expect('Location', 'http://foo.com/500.html')
+      .expect('Redirecting to <a href="http://foo.com/500.html">http://foo.com/500.html</a>.')
+      .expect(302, done);
   });
 });