Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build issues #13

Merged
merged 13 commits into from
Sep 13, 2020
Merged

Fixed build issues #13

merged 13 commits into from
Sep 13, 2020

Conversation

thekalinga
Copy link
Contributor

  1. Fixed the gradle build issues
  2. Fixed the issue with org.xmlpull.v1.XmlPullParserFactory in java 9
  3. Added readme

@stefanhaustein stefanhaustein merged commit bcc95c2 into kobjects:master Sep 13, 2020
@thekalinga
Copy link
Contributor Author

Thanks for merging. Can you publish a new release 3.0.0?

@stefanhaustein
Copy link
Member

stefanhaustein commented Sep 14, 2020 via email

@thekalinga
Copy link
Contributor Author

thekalinga commented Sep 16, 2020

From the end user point of view, couple of things changed

  1. This version does not bomb on java 9 & above (an enhancement)
  2. The data format within src/main/resources/META-INF/services/org.xmlpull.v1.XmlPullParserFactory changed from a format of 1.3.3.1 -> 1.1.4.0 (a bug fix)

Strictly speaking 2.5.0 is most appropriate one, but the reason why I proposed 3.0.0 is because its easy for people to remember that a major change (aka support for java 9) in 3.0.0 than when they look at 2.5.0. I'm okay either ways. I will leave it upto your judgement.

@thekalinga
Copy link
Contributor Author

If you want to keep it at 2.5.0, please update version within build.gradle to 2.5.0 before publishing

@thekalinga
Copy link
Contributor Author

thekalinga commented Sep 16, 2020

After few mins of thinking, 2.5.0 seems the appropriate one as people will know there are no breaking changes from library's point of view. Which makes their lives much simper when making a decision when compared to the case if the library is tagged under 3.0.0

stefanhaustein added a commit that referenced this pull request Sep 17, 2020
@stefanhaustein
Copy link
Member

Ok thanks! So the release tag will be "v2.5.0" for consistency with the others / following github suggestions. Should I include the "v" in build.gradle? Do we need to duplicate the version there at all? I don't seem to have it in any other project?

@thekalinga
Copy link
Contributor Author

Sorry for delay in responding. I dont see any good reason for v prefix.

@thekalinga
Copy link
Contributor Author

Can you publish the release in github so that people can refer to it by 2.5.0 instead of commit number?

@stefanhaustein
Copy link
Member

stefanhaustein commented Sep 30, 2020 via email

@stefanhaustein
Copy link
Member

Released as version 2.5.0 with tag v2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants