Skip to content

Commit

Permalink
Pin Node to v20.17.0 / [email protected]
Browse files Browse the repository at this point in the history
  • Loading branch information
p2edwards committed Aug 23, 2024
1 parent fcc3a3e commit 56e5f47
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/npm-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
matrix:
node-version:
- '16.15.0' # prior pinned Node version supported by kpi
- '20.15.1' # version pinned for kpi release
- '20.17.0' # version pinned for kpi release
fail-fast: false # Let each job finish

steps:
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.15.1
v20.17.0
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.15.1
v20.17.0
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ RUN apt-get -qq update && \
less \
libproj-dev \
locales \
# to pin an exact Node version, see 'git blame' here
nodejs \
# pin an exact Node version for stability. update this regularly.
nodejs=$(apt-cache show nodejs | grep -F 'Version: 20.17.0' | cut -f 2 -d ' ') \
postgresql-client \
procps \
rsync \
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "2.0.0",
"description": "KoboToolbox frontend interface.",
"engines": {
"node": "^20.15.1"
"node": "^20.17.0"
},
"dependencies": {
"@fontsource/roboto": "^4.4.2",
Expand Down
10 changes: 5 additions & 5 deletions scripts/hints.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ if (process.env.SKIP_TS_CHECK && tsCheckAffects.includes(hintName)) {
Show on preinstall. Since it's easy to miss there, also show it on other
run scripts such as 'watch'.
*/
const ok_node = 'v20.15.1';
const ok_npm = '10.7.0';
const ok_node = 'v20.17.0';
const ok_npm = '10.8.2';

if (process.version !== ok_node) {
const blu = '\u001b[94m'; // bright blue
Expand Down Expand Up @@ -114,10 +114,10 @@ if (process.version !== ok_node) {
To switch to a supported Node / npm version:
Use Node v20.15.1, which comes with npm@10.7.0
Use Node ${ok_node}, which comes with npm@${ok_npm}
\`nvm use\` or \`fnm use\`
or \`npm install -g npm@10.7.0\`
or \`npm install -g npm@${ok_npm}\`
to change npm for your current Node`);

console.warn(`${yel}
Expand All @@ -126,7 +126,7 @@ if (process.version !== ok_node) {
(1) Don't commit these changes to package-lock.json
(2) You may want to reset these changes and run
\`npm install\` again with 10.7.0
\`npm install\` again with ${ok_npm}
`);

// If you switch between Node projects and see this message often,
Expand Down

0 comments on commit 56e5f47

Please sign in to comment.