-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the looks of My Projects route and add advanced filtering and configuration #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…209-my-projects-redo # Conflicts: # jsapp/js/projects/customViewStore.ts
…209-my-projects-redo
…209-my-projects-redo # Conflicts: # jsapp/js/projects/projectViews/constants.ts
Base automatically changed from
custom-views-integrate-endpoints-into-front-end
to
feature/regional_projects
January 19, 2023 13:46
# Conflicts: # jsapp/js/lists/forms.es6 # jsapp/js/lists/forms.module.scss
also update backend response type
# Conflicts: # jsapp/js/mixins.tsx
# Conflicts: # jsapp/js/components/assetrow.es6 # jsapp/js/components/assetsTable/assetActionButtons.tsx # jsapp/js/components/header.es6 # jsapp/js/mixins.tsx
magicznyleszek
changed the title
Update My Projects route to use new shiny components
Update the looks of My Projects route and add advanced filtering and configuration
Feb 9, 2023
… especially since the quick actions menu is triggered by checkbox - Wider, taller checkbox click target, extends to the beginning of the next cell - Visually indicate if a click would trigger navigation (soft underline the project name on row hover)
p2edwards
reviewed
Feb 25, 2023
p2edwards
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the My Projects route with the looks introduced with Project Views functionality. New UI allows advanced filtering, column hiding and ordering of the projects. All the settings are being remembered between sessions.
Code Review notes
This includes quite a lot of changes:
/#forms
routeapi.ts
to also work with full urls (currently only paths are allowed)assetQuickActions
:mixins.tsx
hereassetUtils.ts
hereassetUtils.ts
methods to allow bothAssetResponse
andProjectViewAsset
(the asset object that we receive from Project Views endpoint; it has less amount of data than bigAssetResponse
)/#forms
mixins.clickAsset
and am usingassetQuickActions
insteadplacement
handling ofKoboDropdown
(previously you had to importKoboDropdownPlacements
enum and then use one of the values - now you have to simply match the type)userCan
method, so it works withProjectViewAsset
assets (they don't havepermissions
list, onlyeffective_permissions
, so I had to take this into account)customViewStore
has some changes:ProjectQuickActions
ProjectQuickActions
that displays a bunch of buttons for modifying a single asset/#forms
route is no longer being used - now it redirects to new route#/projects/home
projects/projectViews/constants.ts
the fact if they are orderable thorugh API is being set on per route basis (the endpoint used by My Projects doesn't have identical functionality for ordering as Project Views)mixins.floatingRoundedBox;
that adds rounded corners, shadow and white backgroundProjectQuickActions
), in near future we will also haveBulkQuikcActions
for handling multiple selected rowsasset_type
anddownloads
fields toProjectViewAsset
Related issues
Fixes #4209
Fixes #4058
Fixes #4237