Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node 18 and latest npm version #4553

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/npm-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,12 @@ on:

jobs:
build:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
# We need this particular version, as npm 8.5.5 is the last version
# that works with our package.json :sadface:.
node-version: '16.15.0'
node-version: '18.17.0'
cache: 'npm'
- uses: browser-actions/setup-chrome@latest
- run: chrome --version
Expand All @@ -28,7 +26,7 @@ jobs:
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json', 'patches/**/*.patch') }}
- name: Install JavaScript dependencies (npm install)
if: steps.cache-nodemodules.outputs.cache-hit != 'true'
run: npm install
run: npm install --legacy-peer-deps
- name: Run copy-fonts (if using cached node_modules)
if: steps.cache-nodemodules.outputs.cache-hit == 'true'
run: npm run copy-fonts
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/update-translations-strings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ jobs:

- uses: actions/setup-node@v2
with:
# We need this particular version, as npm 8.5.5 is the last version
# that works with our package.json :sadface:.
node-version: '16.15.0'
node-version: '18.17.0'
cache: 'npm'

- name: Change Directories
Expand Down
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ build:
deploy-beta:
stage: deploy
image:
name: alpine/helm:3.12.0
name: alpine/helm:3.12.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah yeah it's unrelated but so small

entrypoint: [""]
script:
- helm repo add kobo https://gitlab.com/api/v4/projects/32216873/packages/helm/stable
Expand Down
1 change: 0 additions & 1 deletion .node-version

This file was deleted.

2 changes: 2 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
legacy-peer-deps=true
engine-strict=true
1 change: 0 additions & 1 deletion .nvmrc

This file was deleted.

3 changes: 1 addition & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ RUN mkdir -p "${NGINX_STATIC_DIR}" && \

RUN apt-get -qq update && \
apt-get -qq -y install curl && \
curl -sL https://deb.nodesource.com/setup_16.x | bash - && \
curl -sL https://deb.nodesource.com/setup_18.x | bash - && \
apt-get -qq -y install --no-install-recommends \
ffmpeg \
gdal-bin \
Expand Down Expand Up @@ -110,7 +110,6 @@ COPY --from=build-python "$VIRTUAL_ENV" "$VIRTUAL_ENV"
WORKDIR ${KPI_SRC_DIR}/

RUN rm -rf ${KPI_NODE_PATH} && \
npm install -g [email protected] && \
npm install -g check-dependencies && \
rm -rf "${KPI_SRC_DIR}/jsapp/fonts" && \
rm -rf "${KPI_SRC_DIR}/jsapp/compiled" && \
Expand Down
Loading
Loading