-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TextBox component #4579
Update TextBox component #4579
Conversation
to prepare it for on-white becoming the default
and start adjusting other code who was hackingly relying on those styles
Since this links to issue #3914, how much of these styles are we adhering to? For example I see that you unified the text box styles with your changes but we don't have the change when searching and letters being bolded. |
@srartese right, sorry - that old issue is not that up-to-date. The latest designs for |
…omponent # Conflicts: # jsapp/js/account/security/password/updatePasswordForm.module.scss
added "startIcon", "endIcon", and "required" options
@srartese I've pushed a lot of changes :P I found a more complete Figma designs and updated everything accordingly (besides option "Populated" x "Error", which I feel has wrong text color by mistake). I also updated the storybook definition for TextBox, so you can test everything there (if you haven't done so already) :) As for the login page (or rather all Django templates), this would require a lot more work and turning those forms into React apps. I will create a separate GH issue for handling that. We might be doing this soon when we redesign those pages (Figma design is already done) |
…omponent # Conflicts: # jsapp/js/account/accountSettingsRoute.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this wasn't a change you made but since we are updating this file should we change these to use the sizes
variables here? IE: margin-right: 24px;
to margin-right: sizes.$x24;
plus some linter cleanups
5ac0c9c
into
feature/password-complexity
Description
Update looks of
TextBox
component and cleanup its usage.Notes
Things here:
TextBox
component - former'on-white'
type is now de-facto only style (notice the plenty places with removedm='on-white'
)12px
and14px
font sizesTextBox
has now 100% widthdescription
option fromTextBox
(never used)TextBox
is now Functional Component with CSS ModuleMetadataEditor
styles to separate file.text-box
directlyConnectProjects
a tiny bitButton
componentfocus-visible
instead offocus
for global focus stylesRelated issues
Fixes #3914