Add tooltip Component for disabled buttons #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuthShryock
changed the title
magicznyleszek
requested changes
Dec 4, 2023
magicznyleszek
requested changes
Dec 11, 2023
RuthShryock
changed the title
magicznyleszek
approved these changes
Dec 13, 2023
magicznyleszek
requested changes
Dec 13, 2023
| {props.isPending && ( | ||
| <Icon name='spinner' size={iconSize} classNames={['k-spin']} /> | ||
| <> | ||
| {props.tooltip !== undefined && ( |
There was a problem hiding this comment.
I've noticed that if you don't add tooltip, this renders nothing. We need the button to be rendered with or without a tooltip :)
There was a problem hiding this comment.
I thought that somethign is wrong with Storybook, because it wasn't rendering anything for Button, so I've added a commit that improves button.stories.tsx. Please take a look at what it does when testing the tooltip:
magicznyleszek
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Notes
Added a
tooltipcomponent which has been added as an attribute to theButtoncomponent and wrote a tooltip.stories.tsx for documentation. Updated all the projectQuickAction and projectBulkAction icons to use the new tooltip component.Related issues
Fixes #4611