Mark org speed test as 'performance', exclude performance tests from running without flag #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…running without flag
jnm
requested changes
Jan 19, 2024
| @@ -138,7 +138,7 @@ def test_doesnt_include_org_users_with_invalid_plan(self): | |||
| self.expected_file_size() * self.expected_submissions_single | |||
| ) | |||
|
|
|||
| @pytest.mark.xfail | |||
| @pytest.mark.performance | |||
There was a problem hiding this comment.
Now that the test is excluded by default, would it be worth cranking up the number of model instances to a number that you would want to use when you run performance tests? (Or, if not, adding a comment describing how someone might use the test to test performance meaningfully?)
pyproject.toml
Outdated
| @@ -21,6 +21,14 @@ extend-select = ["I"] | |||
| [tool.ruff.lint.isort] | |||
| known-first-party = ["kobo"] | |||
|
|
|||
| [tool.pytest.ini_options] | |||
| addopts = [ | |||
| '-m "not performance"', | |||
jnm
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Prevents running a test that should only be run manually from running automatically.