[TASK-624] Allow users to select between translated labels and XML names for displayed form questions in NLP UI #4933

duvld · 2024-05-08T04:22:29Z

Checklist

If you've added code that should be tested, add tests
If you've changed APIs, update (or create!) the documentation
Ensure the tests pass
Make sure that your code lints and that you've followed our coding style
Write a title and, if necessary, a description of your work suitable for publishing in our release notes
Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
Open an issue in the docs if there are UI/UX changes

Description

Adds a selector to the NLP UI to allow switching question label languages. The places that would be affected by such a change are:

Question selection in header
Form questions in sidebar
Display settings list (newly added in [TASK-623] Allow users to select which form questions to display in the single processing side bar #4889)

Notes

Ended up having to pass asset instead of assetContent in some places due to needing the entire AssetResponse in order to use getLanguageIndex. Tried to make these changes minimal but maybe better to just change all cases to use asset instead of sometimes both.

Related issues

Task 624 of NLP improvements

Please enter the commit message for your changes. Lines starting

…dons-task-624-change-displayed-language

WIP CSS

notion-workspace · 2024-05-08T20:46:02Z

Allow users to select between translated labels and XML names for displayed form questions

jsapp/js/components/processing/sidebar/sidebarDisplaySettings.tsx

jsapp/js/components/processing/sidebar/processingSidebar.tsx

jsapp/js/components/processing/sidebar/sidebarDisplaySettings.module.scss

jsapp/js/components/processing/sidebar/sidebarDisplaySettings.tsx

jsapp/js/components/processing/singleProcessingRoute.tsx

jsapp/js/components/processing/singleProcessingStore.ts

and some basic PR changes Conflicts: jsapp/js/components/processing/sidebar/sidebarDisplaySettings.module.scss

jsapp/js/components/processing/sidebar/sidebarLabelsSettings.component.tsx

magicznyleszek · 2024-06-11T12:29:45Z

jsapp/js/components/processing/singleProcessingStore.ts

+        }
+      });
+    } else {
+      languagesList.push({label: t('Default'), value: 'default'});


Could you make it so it works similarly to "Data → Table → Display options" modal? I.e. that you will see the "default" option as being selected? I'm guessing you would need to return 'default' in getInitialDisplayedLanguage instead of empty string. Or change the value: 'default' to value: ''

magicznyleszek · 2024-06-11T12:30:37Z

jsapp/js/components/processing/singleProcessingStore.ts

+  getDisplayedLanguagesList(): KoboSelectOption[] {
+    const languagesList = [];
+
+    languagesList.push({label: t('XML names'), value: 'xml_names'});


In "Data → Table → Display options" modal, if you have a project with no languages being defined, you will see two options: "XML Values" and "Labels" - let's stick to the same naming, so it's clear these are the same.

Tried making the changes for this one and above. Not 100% I understand so lmk if I did it right

jsapp/js/components/processing/singleProcessingStore.ts

magicznyleszek · 2024-06-11T12:39:23Z

jsapp/js/components/processing/sidebar/sidebarLabelsSettings.component.tsx

+      <Button
+        size='m'
+        type='bare'
+        label={t('Change question language')}


I'm not fond of this label. And as I was trying to think about better name, like "Labels settings", "Data settings", I started thinking about moving this into the "Display settings" modal after all… Sorry! Will ask Tessa in public topic about her two cents.

The decision on Zulip topic is to put labels settings inside display settings modal, sorry!

jsapp/js/components/processing/sidebar/sidebarLabelsSettings.component.tsx

TODO: move label display back to display settings

Conflicts: jsapp/js/components/processing/sidebar/processingSidebar.tsx

duvld added 3 commits May 7, 2024 00:30

WIP adding select with languages & store stuff

6e134d2

Please enter the commit message for your changes. Lines starting

Merge branch 'nlp-addons-select-data-questions-displayed' into nlp-ad…

0fafc78

…dons-task-624-change-displayed-language

Select changes languages of question labels

70eb756

WIP CSS

duvld requested a review from magicznyleszek May 8, 2024 04:22

Fix empty string if translations is not made yet

f2aba97

magicznyleszek changed the title ~~Allow users to select between translated labels and XML names for displayed form questions in NLP UI~~ [TASK-624] Allow users to select between translated labels and XML names for displayed form questions in NLP UI May 8, 2024

Base automatically changed from nlp-addons-select-data-questions-displayed to beta May 8, 2024 20:51

magicznyleszek self-assigned this May 10, 2024

magicznyleszek requested changes May 29, 2024

View reviewed changes

duvld added 4 commits May 31, 2024 18:23

Merge branch 'beta' into nlp-addons-task-624-change-displayed-language

66abd5a

and some basic PR changes Conflicts: jsapp/js/components/processing/sidebar/sidebarDisplaySettings.module.scss

PR changes

20eff6e

Missing files

f60448c

Merge branch 'beta' into nlp-addons-task-624-change-displayed-language

5bc2b45

magicznyleszek requested changes Jun 11, 2024

View reviewed changes

duvld and others added 6 commits June 11, 2024 10:51

Some PR changes

0a47813

PR changes

95bc765

TODO: move label display back to display settings

Merge branch 'beta' into nlp-addons-task-624-change-displayed-language

bdcb736

Conflicts: jsapp/js/components/processing/sidebar/processingSidebar.tsx

Move lang select to display setttings and cleanup

dfdd9f2

Merge branch 'beta' into nlp-addons-task-624-change-displayed-language

40ba2a0

tiny cleanup

a832255

magicznyleszek merged commit b6e5a4e into beta Jul 1, 2024
4 checks passed

magicznyleszek deleted the nlp-addons-task-624-change-displayed-language branch July 1, 2024 13:50

This was referenced Oct 16, 2024

Language "_default" shown for exports when "Value and header format" set to "Labels" #5171

Open

[TASK-1164] Fix function that renders language in the downloads table #5172

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TASK-624] Allow users to select between translated labels and XML names for displayed form questions in NLP UI #4933

[TASK-624] Allow users to select between translated labels and XML names for displayed form questions in NLP UI #4933

duvld commented May 8, 2024

notion-workspace bot commented May 8, 2024

magicznyleszek Jun 11, 2024

magicznyleszek Jun 11, 2024

duvld Jun 18, 2024

magicznyleszek Jun 11, 2024

magicznyleszek Jun 14, 2024

[TASK-624] Allow users to select between translated labels and XML names for displayed form questions in NLP UI #4933

[TASK-624] Allow users to select between translated labels and XML names for displayed form questions in NLP UI #4933

Conversation

duvld commented May 8, 2024

Checklist

Description

Notes

Related issues

notion-workspace bot commented May 8, 2024

magicznyleszek Jun 11, 2024

Choose a reason for hiding this comment

magicznyleszek Jun 11, 2024

Choose a reason for hiding this comment

duvld Jun 18, 2024

Choose a reason for hiding this comment

magicznyleszek Jun 11, 2024

Choose a reason for hiding this comment

magicznyleszek Jun 14, 2024

Choose a reason for hiding this comment