chore: add CODEOWNERS file #5213
Merged
+92
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuukis
requested review from
bufke,
jnm,
Guitlle,
magicznyleszek,
p2edwards,
rgraber,
pauloamorimbr,
duvld,
noliveleger,
rajpatel24,
jamesrkiger and
RuthShryock
rgraber
approved these changes
Oct 30, 2024
magicznyleszek
approved these changes
Oct 30, 2024
|
Looks good. I will wait for everyone to take what they want, and I will have the rest 🤑 |
RuthShryock
approved these changes
Oct 30, 2024
Remove my name from files I never touched, added @bufke, @jnm and @JacquelineMorrissette for files they should own.
noliveleger
reviewed
Oct 31, 2024
There was a problem hiding this comment.
@jnm, @bufke , @JacquelineMorrissette please review my changes
bufke
approved these changes
Nov 1, 2024
…and John, and group these entries together
…as the backend lead developer. `CONTRIBUTING.md` applies equally to the backend, and `kpi.code-workspace` contains various settings related to formatting and linting Python code
@noliveleger, I have contradicted a few of them. You can see my rationale in my commit messages. LMK if you want to discuss anything |
jnm
approved these changes
Nov 1, 2024
|
Sorted, grouped and clarified that last line wins. Added the missing github folder, set @p2edwards as owner for patches folder as per his 👍 above. |
Guitlle
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
./python-format.shto make sure that your code lints and that you've followed our coding styleDescription
Internal process configuration with no changes to the product.
Notes
Let's declare ownership of code. Please comment or directly push to this PR to add yourself (or others) to CODEOWNERS before approving. Read more in internal docs. In short:
Testing
Not testable. After merging, should suggest reviewers based on the CODEOWNERS file according to github docs.