Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(billingAddons): normalize NLP usage naming TASK-1015 #5222

Merged

Conversation

jamesrkiger
Copy link
Contributor

@jamesrkiger jamesrkiger commented Nov 4, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Run ./python-format.sh to make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes
  8. Create a testing plan for the reviewer and add it to the Testing section
  9. Add frontend or backend tag and any other appropriate tags to this pull request

Description

Previously we were using 'nlp_character_limit' and 'nlp_minutes_limit' as the keys for nlp usage limits in Stripe metadata. Elsewhere in the code we have been using 'asr_minutes' and 'mt_characters'. This PR removes the Stripe-specific language for consistency. A separate PR will be submitted to update the frontend accordingly.

@jamesrkiger jamesrkiger changed the title Remove USAGE_LIMIT_MAP_STRIPE to stop using nlp_ prefix for addon usa… refactor(Billing addons): switch to mt_characters and asr_minutes TASK-1015 Nov 4, 2024
Copy link

@jamesrkiger jamesrkiger changed the title refactor(Billing addons): switch to mt_characters and asr_minutes TASK-1015 refactor(billing addons): Normalize NLP usage naming TASK-1015 Nov 4, 2024
@jamesrkiger jamesrkiger changed the title refactor(billing addons): Normalize NLP usage naming TASK-1015 refactor(billingAddons): Normalize NLP usage naming TASK-1015 Nov 4, 2024
@jamesrkiger jamesrkiger changed the title refactor(billingAddons): Normalize NLP usage naming TASK-1015 refactor(billingAddons): normalize NLP usage naming TASK-1015 Nov 4, 2024
@jamesrkiger jamesrkiger merged commit 4fef358 into billing-addons-backend Nov 5, 2024
7 checks passed
@jamesrkiger jamesrkiger deleted the task-1015-normalize-usage-naming branch November 5, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants