Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer tweak before new design v0.9 #4378

Closed
yangwao opened this issue Nov 22, 2022 · 4 comments
Closed

Explorer tweak before new design v0.9 #4378

yangwao opened this issue Nov 22, 2022 · 4 comments
Labels

Comments

@yangwao
Copy link
Member

yangwao commented Nov 22, 2022

We will work with @exezbcz about some small and impactful changes to explorer before we come back to redesign the whole explorer after the collection view.

Primary, we will be putting filters on the side like any other marketplace has, which we will be pretty great about.
Plus, we can update buttons to upcoming styles too.
The thing is, we probably won't have time to circle back sooner than 6 weeks tbh

We mostly likely keep all functionality we have
If you have suggestions for explorer, now is your time.

Proposed changes

  • put filters on the side
  • update pagination button to neobrutalism style
  • change the grid of items default based on min-width per card, i.e. @ 1024px will be 4, at @ 1920px be 6-8
  • anything else you are wishing for xmas
  • rename Gallery -> Items
  • add blockchain switch

Current state

image

Ref

@yangwao yangwao changed the title Explorer tweak before new design Explorer tweak before new design v0.9 Nov 22, 2022
@roiLeo
Copy link
Contributor

roiLeo commented Nov 23, 2022

A while ago (#2947) I had started to work on something like this.

167655522-86e1d19c-dc6d-4503-a55d-19718f85259c

If you have suggestions for explorer, now is your time.

I would like to:

  • be able to collapse side filters
  • move sorting option in the top right
  • change grid card size
  • filter by media type (Filter for file type #1162)

Note:

  • should we keep pagination? I don't find so much use since we have infinite scroll

@exezbcz
Copy link
Member

exezbcz commented Nov 23, 2022

A while ago (#2947) I had started to work on something like this.

167655522-86e1d19c-dc6d-4503-a55d-19718f85259c

If you have suggestions for explorer, now is your time.

I would like to:

  • be able to collapse side filters
  • move sorting option in the top right
  • change grid card size
  • filter by media type (Filter for file type #1162)

Note:

  • should we keep pagination? I don't find so much use since we have infinite scroll

Nice! good ideas.
For version 0.9, I believe we will keep things basic before returning to it once the collection detail and other tasks are completed.
Thus we won't be adding many new features to the makeover. It would be only layout change and bit of a reorganizational change.
Things that are going to be in the makeover:

  • collapsible burger menu
  • layout change of the filters
  • items in grid

I dont think we will add filter by media to this version.

ad pagination - @yangwao said its a feature

Thanks!

@yangwao
Copy link
Member Author

yangwao commented Nov 24, 2022

  • should we keep pagination? I don't find so much use since we have infinite scroll
    ad pagination - @yangwao said its a feature

Yes, we can drop pagination (looking R & OS), doesn't make sense now and eats some space.
yet pimp infinite scroll to randomly not bounce on scroll up and test addressing properly. I recall we have bug when you go on item and return back it jumps you on different view port of page

  • be able to collapse side filters
  • move sorting option in the top right
  • change grid card size

yes all of these

filter by media type (#1162)

I'm afraid this will be postponed for later

@yangwao
Copy link
Member Author

yangwao commented Dec 20, 2022

Closing and continue to

@yangwao yangwao closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants