Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 fresh UI update #2947

Merged
merged 51 commits into from
Aug 15, 2022
Merged

💅 fresh UI update #2947

merged 51 commits into from
Aug 15, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 4, 2022

🚧 WIP 🚧

PR type

  • Feature
  • Refactoring

What's new?

TODO

  • fix navbar-shrink
  • dark/light mode (wip need review/tests)
  • new filters ? (design ready)
  • dev compiled warnings ?

Screenshot

lightMode

Screenshot 2022-06-02 at 15-29-34 KodaDot - Kusama NFT Market Explorer

darkMode

Screenshot 2022-06-02 at 15-30-17 KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner May 4, 2022 16:07
@roiLeo roiLeo requested review from vikiival and removed request for a team May 4, 2022 16:07
@netlify
Copy link

netlify bot commented May 4, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit aa4180d
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62fa12bc2a5302000816ea88
😎 Deploy Preview https://deploy-preview-2947--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo marked this pull request as draft May 4, 2022 16:10
@vikiival
Copy link
Member

vikiival commented May 5, 2022

:3 uwu looking forward

@vikiival
Copy link
Member

vikiival commented May 6, 2022

Ping me when ready for review 🔢

@roiLeo
Copy link
Contributor Author

roiLeo commented May 10, 2022

Ping me when ready for review 🔢

Feel free to start reviewing code and design, maybe @XyloDrone can check too

Do I start integrating dark mode on this branch? Same question for the new side filters? (not present in this PR)
Capture d’écran 2022-05-10 à 2 41 54 PM

@vikiival
Copy link
Member

That's lit 🔥

@roiLeo roiLeo modified the milestone: Milestone 1.7 May 12, 2022
@vikiival vikiival removed their request for review May 12, 2022 11:50
@preschian preschian requested review from JustLuuuu and yangwao and removed request for a team August 11, 2022 10:36
@yangwao yangwao requested a review from damskyftw August 11, 2022 12:58
@yangwao
Copy link
Member

yangwao commented Aug 11, 2022

Hey, @JustLuuuu @cryptodamsky let's do click journey thorough whole KodaDot, if you spot something not working lmk; mainly we are looking read-only stuff, if things working okayish :)

Known issues

@yangwao
Copy link
Member

yangwao commented Aug 11, 2022

Beautiful 😍

image

@petersopko
Copy link
Contributor

got this after burning NFT:
image

@petersopko
Copy link
Contributor

when I change the screen to smaller size, I'm capable of achieving this in searchbar on top, not the best look, maybe shorten it back to just "Search..." if the screen is smaller?

image

@JustLuuuu
Copy link
Member

JustLuuuu commented Aug 12, 2022

Light mode: Create (classic) collection: Collection description is still in a dark mode - is that on purpose?
image

Create: Simple/Creative - everything is still in a dark mode
image

When you open NFT - price is also in a dark square
image

@petersopko
Copy link
Contributor

@yangwao
Copy link
Member

yangwao commented Aug 12, 2022

Here he comes

image

@yangwao
Copy link
Member

yangwao commented Aug 13, 2022

Can you make me default white 🥹🙏

@roiLeo
Copy link
Contributor Author

roiLeo commented Aug 13, 2022

Can you make me default white 🥹🙏

Not sure what you mean about that, default color-mode is from user preference:

it will automatically detect the color mode based on the system preferences (see prefers-color-mode spec). The value injected will be either 'light' or 'dark'. If no-preference is detected or the browser does not handle color-mode, it will set the fallback value. (light)

@yangwao
Copy link
Member

yangwao commented Aug 13, 2022

Not sure what you mean about that, default color-mode is from user preference:

we will have by default white only in the upcoming design, so when for example, will be white only landing will redirect the user to black explorer; I sense it would not be looking good :/

@codeclimate
Copy link

codeclimate bot commented Aug 15, 2022

Code Climate has analyzed commit aa4180d and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao yangwao merged commit 9a4d92d into kodadot:main Aug 15, 2022
@yangwao
Copy link
Member

yangwao commented Aug 15, 2022

Let it roll :)
We will add a dark version for the new landing page as well 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign-seeds UX first Improvement for UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants