Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint test failed #10987

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: eslint test failed #10987

merged 1 commit into from
Sep 17, 2024

Conversation

Jarsen136
Copy link
Contributor

PR Type

  • Bugfix

Context

@Jarsen136 Jarsen136 requested a review from a team as a code owner September 16, 2024 14:43
@Jarsen136 Jarsen136 requested review from vikiival and hassnian and removed request for a team September 16, 2024 14:43
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nuxt/[email protected] environment, network +24 10.6 MB antfu

🚮 Removed packages: npm/@nuxt/[email protected], npm/@vitejs/[email protected], npm/@vitest/[email protected], npm/@vitest/[email protected]

View full report↗︎

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit df2e074
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66e84404664ed40008ad64cd
😎 Deploy Preview https://deploy-preview-10987--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Sep 16, 2024

@Jarsen136
Copy link
Contributor Author

This PR only fix the failed eslint test.

As for the Playwright Tests / shard (1, 8), it's a bit wired and I can't find a way to fix it. This e2e test runs without problem in my localhost. The functionality on the page also works normally.

@hassnian @preschian Maybe you have any idea to fix the test?

@vikiival vikiival added this pull request to the merge queue Sep 17, 2024
Merged via the queue into kodadot:main with commit 98d0d56 Sep 17, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants