Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ spotlight backend sorting #1913

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 18, 2022

I'm not able to sort on averagePrice column yet.

PR type

  • Bugfix
  • Feature

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried respect high code quality standards
  • I've didn't break any original functionality

@netlify
Copy link

netlify bot commented Jan 18, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 5f47055

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/61e7c17269f63200078acf60

😎 Browse the preview: https://deploy-preview-1913--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Jan 18, 2022

Is it related? kodadot/rubick#23

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@Prop(String) public account!: string
protected nfts: NftSimpleView[] = []
protected isLoading = true

protected async fetchNFT(account: string) {
const nfts = await this.$apollo.query({
query: nftSimpleListByAccount,
client: this.urlPrefix,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotlight has nothing to do with prefixmixin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikiival it throw this without client
Capture d’écran 2022-01-19 à 8 21 58 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
client: this.urlPrefix,
client: 'subsquid',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not subsquid, rmrk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed some changes

@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 19, 2022

Is it related? kodadot/rubick#23

This is related to #1893 but yes we can try the same with spotlight resolver.

@roiLeo roiLeo marked this pull request as draft January 19, 2022 07:43
@roiLeo roiLeo marked this pull request as ready for review January 19, 2022 07:44
@roiLeo roiLeo merged commit 5f47055 into kodadot:main Jan 19, 2022
@roiLeo
Copy link
Contributor Author

roiLeo commented Jan 19, 2022

shiiiiit

@vikiival
Copy link
Member

/giphy shit

@github-actions
Copy link
Contributor

pile GIF

@roiLeo roiLeo mentioned this pull request Jan 19, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotlight sorting made through backend - Rubick
3 participants