Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emote API fro Berlin Blockchain Week #131

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Emote API fro Berlin Blockchain Week #131

merged 3 commits into from
Aug 26, 2022

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Aug 26, 2022 •
edited
Loading

  • ':zap: resolver to return map count for each emote'
  • ':zap: export emote resolver'
  • 💩 fugly code

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • This PR is required for kodadot/nft-gallery#<issue_number>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

Screenshot 2022-08-26 at 16 21 01

@vikiival
Copy link
Member Author

YOLO

@vikiival vikiival merged commit 157ea36 into main Aug 26, 2022
@vikiival vikiival deleted the bbw-emotes branch August 26, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vikiival