Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ nftEntity totalEmotes #154

Merged
merged 2 commits into from
Oct 13, 2022
Merged

✨ nftEntity totalEmotes #154

merged 2 commits into from
Oct 13, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 13, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

PR type

  • Feature

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases: DB MIGRATION & Property 'totalEmotes' does not exist on type 'NFTEntity'

Screenshot

Capture d’écran 2022-10-13 à 5 11 58 PM

vikiival
vikiival requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just naming

schema.graphql Outdated Show resolved Hide resolved
@vikiival
Copy link
Member

To the naming: I would like to avoid totalEmotes as s evokes Array

  • usually s is also for GraphQL nested entities.

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 13, 2022

updated!

Capture d’écran 2022-10-13 à 5 33 07 PM

@vikiival vikiival merged commit 2ab78d7 into kodadot:main Oct 13, 2022
@roiLeo roiLeo deleted the feature/nftEntity/totalEmotes branch October 14, 2022 06:11
@vikiival vikiival mentioned this pull request Oct 18, 2022
Closed
vikiival added a commit that referenced this pull request Oct 25, 2022
@vikiival
Merge branch 'origin/main' into zlozenec (#153, #154)
cdfd0f3
@roiLeo roiLeo mentioned this pull request Jan 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sort by most reacted
2 participants
@roiLeo @vikiival