-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add highest sale to series insight #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I don't see
highest_sale
in series cached query
- I would add
highest_sale
inOrderBy
series resolver
the rest seems to me correct
edit:
would be top if we can remove burned nft from the queries
WHERE ne.burned != 'false'
(related with #47)
@roiLeo Thanks!!! updated. Edit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do I see highest_price
in db migrations?
do you think it's better to remove burned nft in another PR?
Since we add a new column, I am thinking that we should update DB migrations.
Yes, cause I also want to do some refactoring, and extract those same queries(both in cache and resolvers) into one file. |
Co-authored-by: roiLeo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep it as highest sale
(not highest price)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the highest_sale
used in the SQL queries
Related Issue: issues-877
Hey @vikiival, I get two potential ways to find out the highest sale, could spot me for picking the right one. I'm still confused a bit about the meaning of the scheme.
floor_price
, SQL should beMAX(NULLIF(ne.price, 0)) as highest_sale
Thanks a lot!! And by the time, if there is any issue or refactor should be made, pls don't hesitate to point it out.
This is my first time making a contribution on rubick, excited 😄.