Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolver on hotdashboard #96

Merged
merged 9 commits into from
Oct 18, 2022

Conversation

KngZhi
Copy link
Contributor

@KngZhi KngZhi commented Jun 9, 2022

hot dashboard resolver on stats page.

ref: kodadot/nft-gallery#3114

image

@vikiival
Copy link
Member

Screenshot 2022-06-11 at 15 24 46

this does not look safe

@vikiival
Copy link
Member

Plase also add screenshot from the playground

@KngZhi
Copy link
Contributor Author

KngZhi commented Jun 12, 2022

Plase also add screenshot from the playground

Okay, updated. :)

src/server-extension/query/nft.ts Outdated Show resolved Hide resolved
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol stuff

src/server-extension/query/nft.ts Outdated Show resolved Hide resolved
@vikiival
Copy link
Member

Screenshot 2022-10-18 at 14 48 24

@KngZhi
Copy link
Contributor Author

KngZhi commented Oct 18, 2022

Screenshot 2022-10-18 at 14 48 24

Why not type? I thought it was something wrong with the index file...

Resolve conflicts now, quite long time ago, 😢

@KngZhi KngZhi requested a review from vikiival October 18, 2022 13:06
@vikiival vikiival merged commit cb374e2 into kodadot:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants