-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS 13 Ventura #1297
Comments
I have the first beta up and running in a separate APFS volume.
Relevant system files:
Initial observations:
For reference, here's the yabai window status for a window currently hidden in Stage Manger. Yabai think's it's visible, when in reality it is not, thus causing all other windows on the space to be wrongly tiled. ❯ yabai -m query --windows --space | jq '.[] | select(.app == "Safari")' {
"id": 8204,
"pid": 581,
"app": "Safari",
"title": "macOS 13 Ventura · Issue #1297 · koekeishiya/yabai",
"frame": {
"x": -120,
"y": -1055,
"w": 948,
"h": 1055
},
"role": "AXWindow",
"subrole": "AXStandardWindow",
"display": 2,
"space": 6,
"level": 0,
"opacity": 1,
"split-type": "vertical",
"stack-index": 0,
"can-move": true,
"can-resize": true,
"has-focus": false,
"has-shadow": true,
"has-border": false,
"has-parent-zoom": false,
"has-fullscreen-zoom": false,
"is-native-fullscreen": false,
"is-visible": true,
"is-minimized": false,
"is-hidden": false,
"is-floating": false,
"is-sticky": false,
"is-topmost": false,
"is-grabbed": false
} |
Is I also took a quick look at the Dock.app you uploaded and it should be no problem to update the scripting-addition for this version as well. |
Stage Manager is a single toggle for all non-fullscreen spaces across multiple displays. It operates per non-fullscreen space. Essentially it's like a fancy single-window mode that allows for grouping windows together by dragging them onto a stage on the left side of your screen. Used that way it could be an alternative to spaces as well. |
I can't seem to get yabai scripting addition loaded. I get this error. Output of
When I run |
Also get this. |
Managed to get the yabai scripting addition loaded by following the wiki. @Lalit64 |
Ok. I will try. 😁 |
The scripting-addition won't inject on macOS Ventura because the code requires a versioning change to use the Mach API: I am not particularly interested in programming in my spare time these days, so I have not set up a Ventura partition and I haven't yet looked in details at the changes. My first quick impression has been that everything that currently works on Monterey will continue to work in the foreseeable future. I will pick development back up at some point in the future when I feel motivated/interested enough to do so. |
Any update? How did you manage to get the script addition loaded? |
Hey, I ended up changing the code myself. #1337 has the changes to include checking with macos(13) As said in the pull request, os version checking can be really improved and this is just a quick fix to at least get something working again... |
I am trying to get the offsets and signatures for Dock.app, I saw some comments in monterrey about how to get offsets but I am really lost about this. If anyone is able to help I would appreciate it. I can provide dock.app from ventura 13 beta 2 if needed |
@jorpilo I ended up downgrading my OS to Monterey 12.5. |
i really like to help. if someone can point out the right direction, would be very appreciated. sadly mac os sucks on wm, it’s pretty unusable for me without this awesome app :/ |
I have done this, I hope it can somehow help and I wonder if someone can guide me and tell me if this is correct #1337 (comment) |
How usable is this on the latest upgrade? Am I good to move over or should I wait? |
I wouldn't update unless you really are interested in testing something new on Ventura. If you are yabai is definitely quite good on the beta too, but there are obviously some missing features mainly in the scripting additions. Therefore, I repeat unless you are really interested in using Ventura and willing too not have all the features you may need do not update. On the other hand if you are interested in tinkering and trying to make it work go ahead and update it, but just do not complain if something is not working as you expected. |
@koekeishiya not sure if you've seen it, but Ventura is supposed to go live on Oct 24th, i.e., next Monday. Do you intend to update the scripting addition based on the RC? I can upload the required files as usual if that's the case. |
I'll probably look at it during the weekend if you do |
Took me a while to get to this, but here's everything that should be needed. I can give it a spin post updated signatures, got the Ventura rc2 running now.
|
I looked up the symbols on 12.x based on the signatures (because there's no documentation whatsoever of what they are actually pointing at), then found the differences for the newly released Dock version of Ventura. Hacky workaround, not extensively tested (and will definitely break in the future), here are my "signatures" (merely offsets tbh). The version I've tried this on:
Dock sha256 (if this is not your hash, this will not work for you):
And finally, the patch file is attached. I'd recommend creating a patchfinder that works out of yabai, puts the required offsets into a json or something similar, then the payload will read from it and use it accordingly. This way it would be easier to maintain, and also if the patchfinder runs externally, it is possible (and easy) to make strong signatures that will not break every major. |
See my comment: #1091 (comment) |
Awesome, compiled the latest master and everything works again. git clone https://github.com/koekeishiya/yabai.git
cd yabai
make
make sign
sudo ./bin/yabai --uninstall-sa
sleep 3
sudo ./bin/yabai --load-sa
sleep 3
./bin/yabai I think it's important to uninstall the old scripting additions, it might not be necessary though, and I had to run Thanks so much koekeishiya!! |
Thank you for giving your time to this, @koekeishiya . yabai is a terrific tool, and I'm grateful for the work you put in so we can continue using it. |
Hey guys, awesome news. thanks a lot @koekeishiya 🙏🏼 I am running this, but i can't make it work as brew service.
the accessibility menu is prompt, permission is given, but the permission keeps prompting. Also did the "trick" of stop start again, but the same behaviour. Any suggestions? Thanks again! EDIT:
EDIT2:
if run once on the terminal works, run twice I have that error.
if uninstalled on the terminal, and run the app, also receive that error.
|
You need to follow this detailed instructions. |
Something seems to have changed regarding to how window ordering works in the animation.mp4Additionally I have noticed that there is a |
Thanks you. missed the code sign and the manual add of it. 🙏🏼 |
Weirdly, I'm getting issues on On
I've tried a manual uninstall of scripting additions to ensure I'm not accidentally running an old version. This is testing from |
Looks like this for me on 13.3.1.
I would guess something is wonky about your installation somehow, since it triggers the "out of date" message. Try to stop yabai (also if it is running as a service), remove the scripting-addition manually If you are still having issues after that, upload the Dock.app binary and I can verify that the offsets and patterns match as expected. M2 hardware should not make a difference from M1 hardware for what we are doing. |
Getting "OS Environment does not allow changing security configuration options. Ensure that system was booted into Recovery OS via standard use action" Ventura 13.3.1 (a) Everything else seems to be working fine |
I tested a full uninstall, and also tried using the brew installation method rather than a direct git clone / build. I also tested the new service method and it works well for non-SA required actions, but still fails for focusing windows. |
the yabai binary has been added to the access setting but if i start the service it keeps asking for permission, it does work fine just running it inside a terminal tho, this happened after updating but im pretty sure i followed the instructions for updating correctly, im currently on Ventura 13.0 |
I've verified that all offsets & pattern are correct for the version of the Dock binary that you uploaded, so I don't really know why it won't work for you. As mentioned in my comment above, everything is working fine on my M1 running 13.3.1 (a). |
Thanks for the confirmation. I'll do some more testing from my end and loop back if I figure things out. |
Just a quick note, it looks like yabai works fine on the new 13.4 version. |
Just to summarize the current state: The latest version of yabai works fine on all versions of Ventura up to (and including) version 13.4.
These issues are caused by internal changes in Ventura. These kinds of issues are the most time consuming to solve and I do not have the patience/interest to spend the amount of hours required to see if there even exist workarounds. Assuming that this problem persists in macOS 14 when the time comes, I am leaning more towards simply removing the border system completely. I have been down this path before (v3, v4).. The other option would be to disable borders for macOS Ventura and above, and remove it when Big Sur and Monterey go out of support. |
A small comment: |
@FelixKratz That is a fair point, but I do believe that requires SIP to be disabled to be possible. The current border system does not require SIP to be disabled. I am generally not a fan of forcing users to disable Apple functionality to make base features work properly. I do agree with your point though, that is an option for people who really want window borders (for now anyway). |
It seems that I have to run sudo Does anyone else notice the change? |
check #1471 |
@azinsharaf You are a saint. Issue fixed by adding |
This happened to me and confused me two times. My solution: After getting such complaints, shutdown the computer and do the whole thing again. The second time the computer let me pass :) |
hy, I was wondering if v5.0.6 works fine on Ventura 13.5 for Apple Silicon? I would like to update but before make sure yabai will be OK. Thx |
i am using it on 13.5 on M1 Max for couple of days and haven't seen any issues yet. |
is space switching working fine? considering update |
Works fine on Ventura 13.5.1. |
Just updated, everything is working as it was in monterey |
Can't get it to work on Ventura 13.5.2
Macbook Pro |
Use |
what is your wm , looks so cool |
This is the collective yearly thread for macOS betas. Please use this to discuss instead of opening new issues.
The text was updated successfully, but these errors were encountered: